Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rimraf from 3.0.2 to 5.0.5 #2357

Merged
merged 7 commits into from
Oct 7, 2023
Merged

Bump rimraf from 3.0.2 to 5.0.5 #2357

merged 7 commits into from
Oct 7, 2023

Conversation

nolddor
Copy link
Contributor

@nolddor nolddor commented Oct 7, 2023

This PR replaces #2356

Looks like rimraf v5.0.5 comes with some breaking changes that prevents dependabot to bump this dependency.
This PR should fix the issues, see below for changes:

v4 to v5

There is no default export anymore. 
Import the functions directly using, e.g., import { rimrafSync } from 'rimraf.

v3 to v4

The function returns a Promise instead of taking a callback.

@DABH
Copy link
Contributor

DABH commented Oct 7, 2023

Thank you @nolddor for this heroic effort! 🙏

@DABH DABH merged commit aaaa4c0 into winstonjs:master Oct 7, 2023
3 checks passed
ckujawa added a commit to ckujawa/winston that referenced this pull request Nov 13, 2023
…#1)

* Bump rimraf from 3.0.2 to 5.0.5  (winstonjs#2357)

* Bump rimraf from 3.0.2 to 5.0.5

Bumps [rimraf](https://github.com/isaacs/rimraf) from 3.0.2 to 5.0.5.
- [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md)
- [Commits](isaacs/rimraf@v3.0.2...v5.0.5)

---
updated-dependencies:
- dependency-name: rimraf
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix: rimraf is not a function

* fix: rimraf is not a function

* fix: rimraf is not a function

* fix: done() is not called on mocha hooks

* fix: done() invoked with non-Error

* fix: resolution method is overspecified

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @colors/colors packgae to 1.6.0 (winstonjs#2353)

* Bump actions/checkout from 3 to 4 (winstonjs#2346)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump split2 from 4.1.0 to 4.2.0 (winstonjs#2336)

Bumps [split2](https://github.com/mcollina/split2) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/mcollina/split2/releases)
- [Commits](mcollina/split2@v4.1.0...v4.2.0)

---
updated-dependencies:
- dependency-name: split2
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 3.11.0

* Update dependencies

* Remove nonexistent Logger methods from types

* chore(README.md): adds documentation around coloring json formatted logs

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jack Nolddor <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: James Halsall <[email protected]>
Co-authored-by: DABH <[email protected]>
Co-authored-by: Phillip Huang <[email protected]>
Co-authored-by: Alejandro Campos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants