-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splat is probably broken on latest version (3.2.0) #1584
Comments
Thanks. Will get a bump out for |
Fixed in |
Merged
Thanks for the super fast fix @indexzero |
@indexzero Created a PR that bumps dependencies, including logform. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please tell us about your environment:
winston
version?winston@2
winston@3
node -v
outputs: v10.8.0I had this weird behavior where splat was not working after upgrading Winston, the cause was that
logform
was using different symbols forSPLAT
than Winston.winston
version3.2.0
specifies version1.3.0
oftriple-beam
:https://github.com/winstonjs/winston/blob/master/package.json#L36
But
logform
is using version1.2.0
, see:https://github.com/winstonjs/logform/blob/04a7109031d8ceaf8b93b15d1858d6f05d0a30c1/package.json#L35
This causes different symbols to be used for
SPLAT
, since they were basically different packages. This was the folder structure after anyarn install
:And so this line was returning undefined:
https://github.com/winstonjs/logform/blob/04a7109031d8ceaf8b93b15d1858d6f05d0a30c1/splat.js#L36
The workaround was to set package resolution on package.json:
The text was updated successfully, but these errors were encountered: