[fix] Correct listeners in logException. Fixes #218 #213 #327.

winstonjs · Sep 25, 2015 · 44564de · 44564de
1 parent 87b97cc
commit 44564de
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/lib/winston/transports/transport.js b/lib/winston/transports/transport.js
@@ -113,19 +113,23 @@ Transport.prototype.formatResults = function (results, options) {
 // all logging has completed.
 //
 Transport.prototype.logException = function (msg, meta, callback) {
-  var self = this;
+  var self = this,
+      called;
 
-  function onLogged () {
-    self.removeListener('error', onError);
-    callback();
+  if (this.silent) {
+    return callback();
   }
 
-  function onError () {
-    self.removeListener('logged', onLogged);
-    callback();
+  function onComplete () {
+    if (!called) {
+      called = true;
+      self.removeListener('logged', onComplete);
+      self.removeListener('error', onComplete);
+      callback();
+    }
   }
 
-  this.once('logged', onLogged);
-  this.once('error', onError);
+  this.once('logged', onComplete);
+  this.once('error', onComplete);
   this.log(self.exceptionsLevel, msg, meta, function () { });
 };