Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare vs17 library builds #7

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Prepare vs17 library builds #7

wants to merge 5 commits into from

Commits on Sep 8, 2024

  1. Add support for vs17 builds (for PHP 8.4) 

    We make the necessary additions to `compute-virtuals.ps1`, where the
choice of the WinSDK is somewhat arbitrary but rather conservative.
    @cmb69
    cmb69 committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    071dfd2 View commit details
    Browse the repository at this point in the history

  2. Switch from windows-2019 to windows-2022 runners 

    This is needed to actually be able to do vs17 builds, since that
requires Visual Studio 2022, which is not available on the windows-
2019 runners.  That implies that vc15 builds are no longer possible
without additional changes[1], but that shouldn't be a concern because
none of the supported PHP versions require vc15 builds.

[1] <actions/runner-images#9701>
    @cmb69
    cmb69 committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    2fb3c81 View commit details
    Browse the repository at this point in the history

  3. Update CMake generators 

    Since window-2022 uses Visual Studio 2022, we need to update the CMake
generators; using the proper toolset is already catered to by the `-T`
option.
    @cmb69
    cmb69 committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    2858e77 View commit details
    Browse the repository at this point in the history

  4. Bump vs16 Windows SDK to 10.0.19041.0 

    Windows SDK 10.0.18362.0 is not available on windows-2022 runners.
    @cmb69
    cmb69 committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    1c272e6 View commit details
    Browse the repository at this point in the history

  5. Bump vs16 Windows SDK to 10.0.20348.0 

    This solves the stdalign.h issue for ICU 75.1.
    @cmb69
    cmb69 committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    25f3703 View commit details
    Browse the repository at this point in the history