Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app custom url diff #4914

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: app custom url diff #4914

merged 2 commits into from
Dec 12, 2024

Conversation

HugoCasa
Copy link
Contributor

@HugoCasa HugoCasa commented Dec 12, 2024

Important

Add custom_path support for apps, updating backend models, SQL queries, and frontend components.

  • Backend:
    • Add custom_path field to AppWithLastVersion, AppWithLastVersionAndDraft, and AppWithLastVersionAndStarred structs in apps.rs.
    • Update SQL queries in apps.rs and workspaces.rs to include custom_path.
    • Modify openapi.yaml to reflect custom_path changes in API schema.
  • Frontend:
    • Add custom_path handling in AppEditorHeader.svelte for app creation and updates.
    • Update +page.svelte to manage custom_path in app loading and saving.
  • Misc:
    • Update ee-repo-ref.txt to new commit reference.

This description was created by Ellipsis for 61b4ef4. It will automatically update as commits are pushed.

Copy link

cloudflare-workers-and-pages bot commented Dec 12, 2024

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 414b29d
Status: ✅  Deploy successful!
Preview URL: https://23e0676c.windmill.pages.dev
Branch Preview URL: https://hc-fix-apps-diff.windmill.pages.dev

View logs

@HugoCasa HugoCasa marked this pull request as ready for review December 12, 2024 17:36
@rubenfiszel rubenfiszel merged commit 952cbd1 into main Dec 12, 2024
3 of 4 checks passed
@rubenfiszel rubenfiszel deleted the hc/fix-apps-diff branch December 12, 2024 17:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 61b4ef4 in 1 minute and 9 seconds

More details
  • Looked at 297 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/lib/components/apps/editor/AppEditorHeader.svelte:391
  • Draft comment:
    Ensure that the customPath validation logic correctly handles all edge cases, such as leading/trailing slashes or special characters, to prevent incorrect error messages or validation failures.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code changes in the PR involve adding a custom_path field to various structures and ensuring it is handled correctly in the application logic. This includes updating database queries, API requests, and UI components to accommodate the new field. The changes seem consistent across the backend and frontend, ensuring that the custom_path is included where necessary. However, there is a potential issue with the validation of the custom_path in the frontend, which could lead to incorrect error messages or validation failures.

Workflow ID: wflow_8vjSgc0kG7AbpUoP


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@HugoCasa HugoCasa linked an issue Dec 12, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: App Builder Custom URL Diff Detection
2 participants