Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It crashes when adding a new mural #22

Open
MoralCode opened this issue Nov 6, 2024 · 4 comments
Open

It crashes when adding a new mural #22

MoralCode opened this issue Nov 6, 2024 · 4 comments

Comments

@MoralCode
Copy link
Contributor

its interpreting the year as null when I create a new mural with the year 0000, this is causing database exceptions

While i admit some fault for giving it an invalid year, maybe it shouldnt just crash?

@MoralCode MoralCode changed the title It crashes when i enter 0000 for the year It crashes when adding a new mural Nov 6, 2024
@MoralCode
Copy link
Contributor Author

welp i read the stack trace and that isnt what caused it

seems like active is defaulting to None?

sqlalchemy.exc.IntegrityError: (psycopg2.errors.NotNullViolation) null value in column "active" of relation "murals" violates not-null constraint
DETAIL:  Failing row contains (2, SAU Main Entrance (Outdoor button), t, When entering the SAU from the main quarter mile entrance, its t..., 1, 04, null, null, null).

[SQL: INSERT INTO murals (title, artistknown, notes, year, location, nextmuralid, active, spotify) VALUES (%(title)s, %(artistknown)s, %(notes)s, %(year)s, %(location)s, %(nextmuralid)s, %(active)s, %(spotify)s) RETURNING murals.id]
[parameters: {'title': 'SAU Main Entrance (Outdoor button)', 'artistknown': True, 'notes': 'When entering the SAU from the main quarter mile entrance, its the button for the first (exterior) set of doors', 'year': '0001', 'location': '04', 'nextmuralid': None, 'active': None, 'spotify': None}]
(Background on this error at: https://sqlalche.me/e/20/gkpj)

@MoralCode
Copy link
Contributor Author

seems like the same is true for the spotify field too (what the heck is that for?!)

@wilsonmcdade
Copy link
Owner

Yes there's some issues with mural uploads. Hoping to address that in #21

I'll do some testing and see what the issue is that you're having

@wilsonmcdade
Copy link
Owner

wilsonmcdade commented Nov 7, 2024

seems like the same is true for the spotify field too (what the heck is that for?!)

Some pieces are directly related to popular music from that time:
https://tunnelvision.csh.rit.edu/murals/211
https://tunnelvision.csh.rit.edu/murals/62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants