Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic language negotiation is missing since 2.0 #76

Closed
ruudk opened this issue Dec 18, 2015 · 4 comments
Closed

Generic language negotiation is missing since 2.0 #76

ruudk opened this issue Dec 18, 2015 · 4 comments

Comments

@ruudk
Copy link

ruudk commented Dec 18, 2015

I don't know if this is an mistake or not but this merged PR #65 is missing in 2.0.

$acceptLanguageHeader = 'fr-FR, en-US;q=0.8';
$priorities           = array('fr');
// should return 'fr'
@willdurand
Copy link
Owner

Hi! so this is what you tweeted me the other day, right? It has not been backported I'd say.

@ruudk
Copy link
Author

ruudk commented Dec 21, 2015

Yep I tweet about that.

Would it be easy to have this back in? Because it has been fully rewritten.

@hirbod
Copy link

hirbod commented Sep 21, 2017

will this ever get fixed?

@willdurand
Copy link
Owner

@hirbod this should be fixed by #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants