-
Notifications
You must be signed in to change notification settings - Fork 290
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Latest Electron #241
Comments
+1. Happy to throw some donation $$ to the maintainers if that would help make a difference @Djiit ... |
Nah, just didn't had time. I'll do this tonight. |
whoah sweet thanks! |
that just made my day <3 |
really hoping that maybe kwhat/libuiohook#72 fixes nasty #93 |
It should be ok with 0.6.6, can you test it ? |
Thanks, @Djiit ! Added 0.6.6 to my project using Electron 80 (v9.0.5) but I get this crash immediately on launch (macOS Catalina):
No issues running 0.6.5 with Electron 8.2.0 (76) |
I am having the same issue as above on Windows 10 x64. (Electron 80 : v9.0.5) |
Hu, ok, I have the same. I'll revert the change to make sure nobody try to use it. I'm really sorry but don't have time to work on this right now. Any help would be more than welcome. |
nvm, the version is still OK with older versions. I'll just make it bold in the readme that we need help to support newer versions. |
Same here, Windows 10. Simple test using https://github.com/electron/electron-quick-start and installing iohook, adding |
I was able to compile iohook on Windows 10 x64 for Electron v9.2.0 using |
Thanks, it's working fine with the node-gyp. |
Dumb question here. How did you compile it using node-gyp? |
I created the following files binding.gyp and uiohook.gyp before running the node-gyp to compile the iohook. binding.gyp
uiohook.gyp
Build
|
Thanks :) I'll try this one. |
Hey @ykhwong , would you be interested in opening a PR that introduce node-gyp usage ? It could help us to support Electron 9 and 10 (and other versions). Thanks! |
Any update on this. It would be really helpful for electron 9 and 10 versions. |
|
Looks complicated to me. So I ended up downgrading my electron version :) |
Hey @ykhwong , many thanks ! I'll review this over the weekend. |
Closing as resolved. |
Is there any plan on making iohook compatible with the latest Electron?
I really liked using it but now I'm forced to use the newest Electron version and everything feels off without iohook.
Thanks in advance,
Orfeas.
The text was updated successfully, but these errors were encountered: