Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused SASS Code #1758

Open
datengraben opened this issue Feb 6, 2025 · 0 comments
Open

Unused SASS Code #1758

datengraben opened this issue Feb 6, 2025 · 0 comments
Labels
documentation question Further information is requested technical Non-functional changes (refactorings or increase test coverage)

Comments

@datengraben
Copy link
Contributor

Maybe we can remove the themes SASS directory. But some of it looks like it's patching existing themes to be able to display commonsbooking components.

If we want to support this in the future, we should investigate. I did not know we did have these style patches.

https://github.com/wielebenwir/commonsbooking/tree/master/assets/public/sass/themes
@datengraben datengraben added documentation question Further information is requested technical Non-functional changes (refactorings or increase test coverage) labels Feb 6, 2025
@datengraben datengraben mentioned this issue Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation question Further information is requested technical Non-functional changes (refactorings or increase test coverage)
Projects
commonsbooking (> v2.0.0)
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@datengraben