Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

won't remove resend messages if PUBREC is faster than message pushed #136

Closed
sunnyanthony opened this issue Oct 15, 2021 · 1 comment
Closed

won't remove resend messages if PUBREC is faster than message pushed #136

sunnyanthony opened this issue Oct 15, 2021 · 1 comment

Comments

@sunnyanthony
Copy link
Contributor

sunnyanthony commented Oct 15, 2021 •
edited
Loading

gmqtt/gmqtt/client.py

Lines 197 to 198 in 50bc083

await asyncio.sleep(0.001)
await self._persistent_storage.push_message(mid, package)

The order will cause _handle_pubrec_packet does not properly remove messages.
If client sends packages out and very soon to get PUBREC, it will not remove this message before pushing back.

The suggestion:

-  await asyncio.sleep(0.001) 
   await self._persistent_storage.push_message(mid, package)
+  await asyncio.sleep(0.001)
@sunnyanthony sunnyanthony mentioned this issue Oct 15, 2021
Merged
@sunnyanthony sunnyanthony changed the title won't remove resend messages if PUBREC is faster than pushing message won't remove resend messages if PUBREC is faster than message pushed Oct 15, 2021
@Lenka42
Copy link
Collaborator

Lenka42 commented Oct 18, 2021

@sunnyanthony thanks for the issue and PR. Seems legit 👍 check version 0.6.11

@Lenka42 Lenka42 closed this as completed Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunnyanthony @Lenka42