filter supplied headers (#25)

whopio · Dec 12, 2022 · 37bcc17 · 37bcc17
1 parent 9afc305
commit 37bcc17
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "whop-sdk-ts",
-  "version": "0.0.4-canary.0",
+  "version": "0.0.4-canary.1",
   "private": true,
   "workspaces": [
     "apps/*",

diff --git a/packages/core/request/browser/core/request.ts b/packages/core/request/browser/core/request.ts
@@ -148,10 +148,20 @@ const getHeaders = async (
   const password = await resolve(options, config.PASSWORD);
   const additionalHeaders = await resolve(options, config.HEADERS);
 
+  const suppliedHeaders = Object.entries(options.headers || {})
+    .filter(([_, value]) => isDefined(value))
+    .reduce(
+      (headers, [key, value]) => ({
+        ...headers,
+        [key]: String(value),
+      }),
+      {} as Record<string, string>
+    );
+
   const headers = Object.entries({
     Accept: "application/json",
     ...additionalHeaders,
-    ...options.headers,
+    ...suppliedHeaders,
   })
     .filter(([_, value]) => isDefined(value))
     .reduce(

diff --git a/packages/core/request/node/core/request.ts b/packages/core/request/node/core/request.ts
@@ -158,10 +158,20 @@ const getHeaders = async (
   const password = await resolve(options, config.PASSWORD);
   const additionalHeaders = await resolve(options, config.HEADERS);
 
+  const suppliedHeaders = Object.entries(options.headers || {})
+    .filter(([_, value]) => isDefined(value))
+    .reduce(
+      (headers, [key, value]) => ({
+        ...headers,
+        [key]: String(value),
+      }),
+      {} as Record<string, string>
+    );
+
   const headers = Object.entries({
     Accept: "application/json",
     ...additionalHeaders,
-    ...options.headers,
+    ...suppliedHeaders,
   })
     .filter(([_, value]) => isDefined(value))
     .reduce(