Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginning (and maybe ending) annotation constants in the JS of this library are wrong for my version's JS bundle #5

Open
jason102 opened this issue Nov 25, 2021 · 0 comments

Comments

@jason102
Copy link

I tried this library as it seemed to be the best option at the moment, but it didn't work for me. I debugged the JS and this is what I found:
code

Reading the bundle file is successful (the checkmark). But the next step, splitting it up by looking for "JSO-BEG" does not (the line with an X). This substring doesn't exist anywhere in my minified bundle.

In addition, I don't fully understand why the variable fileNames is passed into these functions as an empty array. As it's empty, that map() doesn't do anything. I'm guessing it should?

Obviously this code works by looking for flags in the bundle such as "JSO-BEG". I guess my newer versions of RN or Metro either use new flags (who knows what they are?) or doesn't use flags at all anymore? Note that I only tried this for ./gradlew assembleRelease (Android).

My version info:
metro: 0.66.2
react-native: 0.65.1

I'm guessing these flags were working for previous versions? Anyone know how the code can be fixed for the more recent versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant