Whist README

This repository is Whist's fork of brave-browser, with a few modifications. We forked brave-browser so that we could build Whist integrated within Chromium on top of Brave, to benefit from Brave's features and development pipeline.

Development

If you are rebasing on upstream, follow the steps here. For regular development, skip straight to the Building section below.

Before building or modifying the code, you should pull the latest changes from the public brave/brave-browser repository that this repository is forked from. To setup your repository, follow these steps:

Clone and enter the repository

git clone https://github.com/whisthq/brave-browser && cd brave-browser

Add the upstream repository as a remote

git remote add upstream https://github.com/brave/brave-browser

Disable pushing to upstream Brave Browser

git remote set-url --push upstream DISABLE

After this, you should be able to list your remotes with git remote -v if you ever need to debug.

Since Brave is a large and active project, we will very often want to work with the latest upstream code; meanwhile, we need to make sure that our own repository has a sane commit history -- we cannot simply periodically merge the latest Brave Browser on top of our own modifications.

Instead, perform the following steps to incorporate changes from upstream:

Fetch the latest changes to the upstream remote

git fetch upstream

Rebase on top of your current work

git rebase upstream/master
# git rebase upstream/<desired branch> for other upstream branches

Resolve merge conflicts, if any arise, and push to the Whist Brave Browser repository

git push origin <current branch>

Building

Note that building Whist's Brave also builds the Whist protocol, meaning you also need the dependencies for building it on your system (Cmake, etc.). Pleaser refer to whisthq/whist as needed. To build Brave, you need:

A NodeJS LTS version. As of writing, this is NodeJS 16.x. Note that some build commands might still work if you don't have that version, and things will fail later on with cryptic errors, so it is better to make sure you are on the right version at the start. We recommend that you install Node Version Manager via your system's package manager (Brew, Apt, Chocolatey/Winget) to easily manage your NodeJS versions. You can then install a specific version of NodeJS, here nvm install 16, and switch to it via nvm use 16 or nvm use 16.16.0. You need to use NPM 8.5.5 to build on macOS, Windows and/or Linux, via npm install -g [email protected].
If you are building on macOS, you also need to have Xcode fully installed (the application, the CLI tools, and Rosetta if you are on arm64). You can install the application from the macOS App Store, and you can install the CLI tools via xcode-select --install in your terminal, once you have the Xcode application. You then need to launch Xcode to trigger the Rosetta install. Note that this will require >18GB of available storage. Please ensure Xcode is on the latest version before building, as updating Xcode will restart the entire build process.
If you are building on Windows, please follow the below instructions:
- Install Visual Studio Community 2019-2022, including Universal Windows Platform development and Desktop development with C++. Try to not install NodeJS, or if you do, ensure that it doesn't conflict with the nvm-installed NodeJS as described above to ensure that you're on the right version.
- Install Windows 10 SDK Version 2104 (10.0.20348.02).
- Note that you will need 22GB of RAM during npm run init. Please increase your pagefile size. You can decrease / remove the pagefile size modification before npm run build, especially if you need the hard drive space.
- Note that you may need to enable LongFilePaths to compile on Windows. On some Windows installations, LongFilePaths doesn't work, even when the registry is set. If this happens to you, move brave-browser to C:\brave-browser in order to compile.
- Install the Windows dependencies of Whist Protocol as well, namely cmake, and configure awscli.
- Note that will you have to use x86_64 Visual Studio Developer Command Prompt (which may be named x64 Visual Studio Developer Command Prompt), in order to compile Whist, which happens at the end of the npm run build step.
If you are building on Linux, firsst run sudo apt-get install -y pkg-config build-essential, and then run ./src/build/install-build-deps.sh.
Lastly, building Brave requires ~100GB of available storage for a Component or Debug build, and ~150GB for a Release build. We recommend that you have at least 120GB of available storage on your device before starting to work on Brave/Chromium to avoid any issues.

Once you're ready, simply follow the instructions from the Build Brave section below!

Publishing

This project gets published nightly for our dev environment, and for every push on our staging and prod environments, from the whist-build-and-deploy.yml workflow within whisthq/whist.

Brave README

Overview

This repository holds the build tools needed to build the Brave desktop browser for macOS, Windows, and Linux. In particular, it fetches and syncs code from the projects defined in package.json and src/brave/DEPS:

Chromium
- Fetches code via depot_tools.
- sets the branch for Chromium (ex: 65.0.3325.181).
brave-core
- Mounted at src/brave.
- Maintains patches for 3rd party Chromium code.
adblock-rust
- Implements Brave's ad-block engine.
- Linked through brave/adblock-rust-ffi.

Downloads

You can visit our website to get the latest stable release.

Other repositories

For other versions of our browser, please see:

iOS - brave/brave-ios

Contributing

Please see the contributing guidelines.

Community

Join the Q&A community if you'd like to get more involved with Brave. You can ask for help, discuss features you'd like to see, and a lot more. We'd love to have your help so that we can continue improving Brave.

Help us translate Brave to your language by submitting translations at https://www.transifex.com/brave/brave/.

Follow @brave on Twitter for important news and announcements.

Install prerequisites

Follow the instructions for your platform:

Clone and initialize the repo

Once you have the prerequisites installed, you can get the code and initialize the build environment.

git clone [email protected]:whisthq/brave-browser.git
cd brave-browser
npm install

# By default, the `dev` branch of whisthq/brave-core and `whisthq/whist` will be built. To build
# a specific branch simply export the respective environment variable below before running `npm
# run init` or `npm run sync`.
export npm_config_projects_brave_core_branch=<brave-core-branch-you-want>
export npm_config_projects_whist_branch=<whist-branch-you-want>

# This downloads the Chromium source, which has a large history. It might take
# a really long time to finish the first time you run it (many hours)
npm run init

Use set instead of export if using the x64 Visual Studio Developer Command Prompt.

Brave-core based Android builds should use npm run init -- --target_os=android --target_arch=arm (or whatever CPU type you want to build for).

npm config set target_os android
npm config set target_arch arm

Build Brave

The default build type is Component. We recommend that you use this build type for developing. For the Whist integration to work, you must first set the required Whist environment variables before building:

# bash
export WHIST_AUTH0_CLIENT_ID=<AUTH0_CLIENT_ID>
export WHIST_AUTH0_DOMAIN_URL=<AUTH0_DOMAIN_URL>
export WHIST_AUTH0_REDIRECT_URL=<AUTH0_REDIRECT_URL>
export WHIST_SCALING_SERVICE_URL=<SCALING_SERVICE_URL>

# x64 Visual Studio Developer Command Prompt
set WHIST_AUTH0_CLIENT_ID=<AUTH0_CLIENT_ID>
set WHIST_AUTH0_DOMAIN_URL=<AUTH0_DOMAIN_URL>
set WHIST_AUTH0_REDIRECT_URL=<AUTH0_REDIRECT_URL>
set WHIST_SCALING_SERVICE_URL=<SCALING_SERVICE_URL>

If you are planning to test locally against your own development instance, you'll also want to set WHIST_HOST_IP. Please refer to the Chromium Auth application in the Auth0 dashboard for the client ID and domain URL, within a specific Auth0 tenant. At the time of writing, the values you need to pass to connect against our dev environment are:

Client ID: DIy0YQZrMeMO97Thjr13EpkGCy792XWx
Domain URL: fractal-dev.us.auth0.com
Redirect URL: https://com.whist.auth0/callback
Scaling-Service URL: https://dev-scaling-service.whist.com

Then, run the build script. The build command will build Brave, the WhistClient library and the Whist Extension.

# start the component build compile
npm run build

To do a release build:

# start the release compile
npm run build Release

Brave-core based Android builds should use npm run build -- --target_os=android --target_arch=arm or set the npm config variables as specified above for init

Build Configurations

Running a release build with npm run build Release can be very slow and use a lot of RAM, especially on Linux with the Gold LLVM plugin.

To run a statically linked build (takes longer to build, but starts faster):

npm run build -- Static

To run a debug build (Component build with is_debug=true):

npm run build -- Debug

Brave staff may also want to try Goma for faster builds.

Run Brave

To start the build:

npm start [Release|Component|Static|Debug]

Update Brave

npm run sync -- [--force] [--init] [--create] [brave_core_ref]

This will attempt to stash your local changes in brave-core, but it's safer to commit local changes before running this

npm run sync will (depending on the below flags):

📥 Update sub-projects (chromium, brave-core) to latest commit of a git ref (e.g. tag or branch)
🤕 Apply patches
🔄 Update gclient DEPS dependencies
⏩ Run hooks (e.g. to perform npm install on child projects)

flag	Description
`[no flags]`	updates chromium if needed and re-applies patches. If the chromium version did not change, it will only re-apply patches that have changed. Will update child dependencies only if any project needed updating during this script run. Use this if you want the script to manage keeping you up to date instead of pulling or switching branches manually.
`--force`	updates both Chromium and brave-core to the latest remote commit for the current brave-core branch and the Chromium ref specified in brave-browser/package.json (e.g. `master` or `74.0.0.103`). Will re-apply all patches. Will force update all child dependencies. Use this if you're having trouble and want to force the branches back to a known state.
`--init`	force update both Chromium and brave-core to the versions specified in brave-browser/package.json and force updates all dependent repos - same as `npm run init`
`--ignore_chromium`	Will not update the chromium version when applicable. Useful if you want to avoid a minor update when not ready for the larger build time a chromium update may result in. A warning will be output about the current code state expecting a different chromium version. Your build may fail as a result.

Run npm run sync brave_core_ref to checkout the specified brave-core ref and update all dependent repos including chromium if needed.

Scenarios

Create a new branch:

brave-core> git checkout -b branch_name

Checkout an existing branch or tag:

brave-core> git fetch origin
brave-core> git checkout [-b] branch_name
brave-core> npm run sync
...Updating 2 patches...
...Updating child dependencies...
...Running hooks...

Update the current branch to the latest remote:

brave-core> git pull
brave-core> npm run sync
...Updating 2 patches...
...Updating child dependencies...
...Running hooks...

Reset to latest brave-browser master and brave-core master (via `init`, will always result in a longer build and will remove any pending changes in your brave-core working directory):

brave-browser> git checkout master
brave-browser> git pull
brave-browser> npm run sync -- --init

When you know that DEPS didn't change, but .patch files did (quickest attempt to perform a mini-sync before a build):

brave-core> git checkout featureB
brave-core> git pull
brave-browser> npm run apply_patches
...Applying 2 patches...

Enabling third-party APIs:

Google Safe Browsing: Get an API key with SafeBrowsing API enabled from https://console.developers.google.com/. Update the GOOGLE_API_KEY environment variable with your key as per https://www.chromium.org/developers/how-tos/api-keys to enable Google SafeBrowsing.

Development

Security rules: https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/security/rules.md

Troubleshooting

See Troubleshooting for solutions to common problems.

Name		Name	Last commit message	Last commit date
Latest commit History 5,840 Commits
.github		.github
docs/source		docs/source
lib		lib
scripts		scripts
src		src
.gitattributes		.gitattributes
.gitignore		.gitignore
.sonarcloud.properties		.sonarcloud.properties
CHANGELOG_ANDROID.md		CHANGELOG_ANDROID.md
CHANGELOG_DESKTOP.md		CHANGELOG_DESKTOP.md
Jenkinsfile		Jenkinsfile
LICENSE		LICENSE
README.md		README.md
SECURITY.md		SECURITY.md
package-lock.json		package-lock.json
package.json		package.json

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Repository files navigation

Whist README

Development

Building

Publishing

Brave README

Overview

Downloads

Other repositories

Contributing

Community

Install prerequisites

Clone and initialize the repo

Build Brave

Build Configurations

Run Brave

Update Brave

Scenarios

Create a new branch:

Checkout an existing branch or tag:

Update the current branch to the latest remote:

Reset to latest brave-browser master and brave-core master (via `init`, will always result in a longer build and will remove any pending changes in your brave-core working directory):

When you know that DEPS didn't change, but .patch files did (quickest attempt to perform a mini-sync before a build):

Enabling third-party APIs:

Development

Troubleshooting

About

Contributors 3

Languages

License

philippemnoel/whist-brave-browser

Folders and files

Latest commit

History

Repository files navigation

Whist README

Development

Building

Publishing

Brave README

Overview

Downloads

Other repositories

Contributing

Community

Install prerequisites

Clone and initialize the repo

Build Brave

Build Configurations

Run Brave

Update Brave

Scenarios

Create a new branch:

Checkout an existing branch or tag:

Update the current branch to the latest remote:

Reset to latest brave-browser master and brave-core master (via init, will always result in a longer build and will remove any pending changes in your brave-core working directory):

When you know that DEPS didn't change, but .patch files did (quickest attempt to perform a mini-sync before a build):

Enabling third-party APIs:

Development

Troubleshooting

About

Topics

Resources

License

Security policy

Stars

Watchers

Forks

Contributors 3

Languages

Reset to latest brave-browser master and brave-core master (via `init`, will always result in a longer build and will remove any pending changes in your brave-core working directory):