Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Avoid leaking internal temporary slots from registry entries #75

Closed
caridy opened this issue Aug 21, 2015 · 2 comments
Closed

Comments

@caridy
Copy link
Contributor

caridy commented Aug 21, 2015

@guybedford mentioned something concerning a while ago, the fact that existing API will allow a user to inquire the loader about a particular module to get access to some internal slots from the registry entry, which included a wrapping promise for its various states, which implies that we will have to hold forever any reference to the source text, and all the internal stuff we need to instantiate a module.

In PR #65 we have started the preliminar work to abstract that out by introducing statePromise alongside state value, to only expose the promise associated to the current state. In theory, we should be able to collect promises from previous states along the way. We will need more iteration on this.

@caridy
Copy link
Contributor Author

caridy commented Aug 21, 2015

initially addressed by #65

@caridy
Copy link
Contributor Author

caridy commented Oct 23, 2015

this is solved now, and #97 will make it every simpler.

@caridy caridy closed this as completed Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant