Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: embrace that attributes are objects #805

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 6, 2019

Closes #801.


Preview | Diff

@annevk
Copy link
Member Author

annevk commented Dec 6, 2019

@nox @pmdartus this might be of interest. It mainly reduces redundancy, which the attribute section had plenty of due to the desire to get rid of Attr and that then failing.

@annevk
Copy link
Member Author

annevk commented Dec 6, 2019

@domenic this also refactors some of the custom element attribute callback steps.

koto added a commit to koto/dom that referenced this pull request Dec 10, 2019
Allows for integrating with Trusted Types - see whatwg#789. Contains whatwg#805.
@annevk annevk merged commit 0038d09 into master Dec 11, 2019
@annevk annevk deleted the annevk/attr-objects branch December 11, 2019 17:40
koto added a commit to koto/dom that referenced this pull request Dec 12, 2019
Allows for integrating with Trusted Types - see whatwg#789. Contains whatwg#805.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Editorial: remove parent argument to remove
1 participant