Skip to content

Commit 3b7f919

Browse files
committed
[improve][writer][elasticsearch] use StringBuilder to replace string concat
1 parent fa63fb8 commit 3b7f919

File tree

1 file changed

+4
-9
lines changed
  • plugin/writer/elasticsearchwriter/src/main/java/com/wgzhao/addax/plugin/writer/elasticsearchwriter

1 file changed

+4
-9
lines changed

Diff for: plugin/writer/elasticsearchwriter/src/main/java/com/wgzhao/addax/plugin/writer/elasticsearchwriter/ESWriter.java

+4-9
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ private long doBatchInsert(final List<Record> writerBuffer)
349349
final Bulk.Builder bulkAction = new Bulk.Builder().defaultIndex(this.index).defaultType(this.type);
350350
for (Record record : writerBuffer) {
351351
data = new HashMap<>();
352-
String id = null;
352+
StringBuilder id = new StringBuilder();
353353
for (int i = 0; i < record.getColumnNumber(); i++) {
354354
Column column = record.getColumn(i);
355355
String columnName = columnList.get(i).getName();
@@ -374,12 +374,7 @@ private long doBatchInsert(final List<Record> writerBuffer)
374374
else {
375375
switch (columnType) {
376376
case ID:
377-
if (id != null) {
378-
id += record.getColumn(i).asString();
379-
}
380-
else {
381-
id = record.getColumn(i).asString();
382-
}
377+
id.append(record.getColumn(i).asString());
383378
break;
384379
case DATE:
385380
try {
@@ -429,12 +424,12 @@ private long doBatchInsert(final List<Record> writerBuffer)
429424
}
430425
}
431426

432-
if (id == null) {
427+
if (id.capacity() == 0) {
433428
//id = UUID.randomUUID().toString()
434429
bulkAction.addAction(new Index.Builder(data).build());
435430
}
436431
else {
437-
bulkAction.addAction(new Index.Builder(data).id(id).build());
432+
bulkAction.addAction(new Index.Builder(data).id(id.toString()).build());
438433
}
439434
}
440435

0 commit comments

Comments
 (0)