Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Leg Probabilities due to Incorrect Copy of Features #67

Closed
semeyerz opened this issue Apr 1, 2019 · 0 comments · Fixed by #68
Closed

Random Leg Probabilities due to Incorrect Copy of Features #67

semeyerz opened this issue Apr 1, 2019 · 0 comments · Fixed by #68

Comments

@semeyerz
Copy link
Contributor

semeyerz commented Apr 1, 2019

With the current kinetic version we were not able to get reasonable leg probabilities.

I looked into the changes since OpenCV and found a major bug in https://github.com/wg-perception/people/blame/kinetic/leg_detector/src/leg_detector.cpp#L731
that was introduced with #53

Here float values are assigned to uchar[i].
This messes up the whole feature vector and thus the classification becomes basically randomized.

Also the probability calculation looks wrong to me.
Right now it is: 0.5 - fuzzy_value/num_trees
As fuzzy_value is between the classes -1(rejection) and 1(leg) the resulting probability would be between -0.5 and 1.5.

You can find our fixed version here: https://github.com/CentralLabFacilities/people/tree/kinetic_cv3
As there are multiple changes(that are already pretty old but increased the quality of tracking).
I will try to find time to create a pull request that at least fixes the major bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant