Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Nightwave challenge isDaily default to false #430

Merged
merged 2 commits into from
Jan 19, 2023
Merged

fix: Nightwave challenge isDaily default to false #430

merged 2 commits into from
Jan 19, 2023

Conversation

SlayerOrnstein
Copy link
Member

@SlayerOrnstein SlayerOrnstein commented Jan 18, 2023 •
edited
Loading

What did you fix?

When parsing nightwave weekly challenges isDaily would disappear from the data instead of defaulting to false.

Reproduction steps

  1. parse worldstate.

Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? No
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? No
  • Have I run the linter? Yes
  • Is is a bug fix, feature request, or enhancement? Bug Fix

@SlayerOrnstein SlayerOrnstein marked this pull request as ready for review January 18, 2023 12:02
@SlayerOrnstein SlayerOrnstein requested a review from a team as a code owner January 18, 2023 12:02
@TobiTenno TobiTenno changed the title Nightwave challenge isDaily should default to false when not present in weekly challlenges fix: Nightwave challenge isDaily default to false Jan 19, 2023
@TobiTenno TobiTenno enabled auto-merge (squash) January 19, 2023 02:34
@TobiTenno TobiTenno merged commit e0f19aa into WFCD:master Jan 19, 2023
@wfcd-bot-boi
Copy link
Contributor

🎉 This PR is included in version 2.26.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiTenno TobiTenno TobiTenno approved these changes

@EricSihaoLin EricSihaoLin Awaiting requested review from EricSihaoLin EricSihaoLin is a code owner automatically assigned from WFCD/node-libraries

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SlayerOrnstein @wfcd-bot-boi @TobiTenno