Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translator being canceled out #410

Merged
merged 1 commit into from
Sep 25, 2022
Merged

fix: translator being canceled out #410

merged 1 commit into from
Sep 25, 2022

Conversation

SlayerOrnstein
Copy link
Member

What did you fix?

Mistake number 2 cancelling out the work that was done with translator with the second call to this.translations[message.LanguageCode]


Evidence/screenshot/link to line

    /**
     * Translation of the news item
     * @type {Object.<string, string>}
     */
    this.translations = {};
    data.Messages.forEach((message) => {
      if (langString.test(message.Message)) {
        this.translations[message.LanguageCode] = translator.languageString(message.Message, message.LanguageCode);
      }

      this.translations[message.LanguageCode] = message.Message;
    });

Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? [No
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? No
  • Have I run the linter? No
  • Is is a bug fix, feature request, or enhancement? Bug Fix

@TobiTenno TobiTenno enabled auto-merge (squash) September 25, 2022 03:52
@TobiTenno TobiTenno merged commit bfed77a into WFCD:master Sep 25, 2022
@wfcd-bot-boi
Copy link
Contributor

🎉 This PR is included in version 2.25.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants