Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translate news when there's a lang #408

Merged
merged 2 commits into from
Sep 21, 2022
Merged

fix: translate news when there's a lang #408

merged 2 commits into from
Sep 21, 2022

Conversation

SlayerOrnstein
Copy link
Member

What did you fix?

Looks like DE is using a lang for it's discord join entry, this will in theory only translate the string when one is detected for both message and translations.


Evidence/screenshot/link to line

{
    "id": "62d31b87106360aa5703954d",
    "message": "/Lotus/Language/CommunityMessages/JoinDiscord",
    "link": "https://discord.com/invite/playwarframe",
    "imageLink": "https://i.imgur.com/CNrsc7V.png",
    "priority": false,
    "date": "2022-07-16T20:10:00.000Z",
    "eta": "66d 19h 13m 55s ago",
    "update": false,
    "primeAccess": false,
    "stream": false,
    "translations": {
      "en": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "fr": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "it": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "de": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "es": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "pt": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "ru": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "pl": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "uk": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "tr": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "ja": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "zh": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "ko": "/Lotus/Language/CommunityMessages/JoinDiscord",
      "tc": "/Lotus/Language/CommunityMessages/JoinDiscord"
    },
    "asString": "[66d 19h 13m 55s ago] [/Lotus/Language/CommunityMessages/JoinDiscord](https://discord.com/invite/playwarframe)"
  }

Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? No
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? No
  • Have I run the linter? Yes
  • Is is a bug fix, feature request, or enhancement? Bug Fix

test/unit/news.spec.js Outdated Show resolved Hide resolved
@TobiTenno TobiTenno marked this pull request as ready for review September 21, 2022 21:50
@TobiTenno TobiTenno requested a review from a team as a code owner September 21, 2022 21:50
@TobiTenno TobiTenno merged commit c3b1da5 into WFCD:master Sep 21, 2022
@wfcd-bot-boi
Copy link
Contributor

🎉 This PR is included in version 2.25.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants