Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Release Checklist #6341

Open
3 tasks
wez opened this issue Oct 31, 2024 · 7 comments
Open
3 tasks

Next Release Checklist #6341

wez opened this issue Oct 31, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@wez
Copy link
Owner

wez commented Oct 31, 2024

BEFORE YOU COMMENT: please avoid duplicating information from other comments to avoid overwhelming this one.
Prefer to use a thumbs up instead of a me-too comment.

We're overdue for making a new release.
Here's what's on my mind as release gating issues, and I need your help to check these off.
So if you are interested in having a new stable tag, please help by running through the list below and giving some feedback on the state of these things for your system:

  • Verify that Wayland support isn't an obvious regression since the last stable release.

    • Wayland support was essentially rewritten by the community, and since I don't use wayland, I don't have sufficient context now to understand where it has problems either in the code or due to compatibility.
    • If you are a Wayland user, and you are using a wezterm nightly build from October 2024 or later and having a good experience, please comment below with the name of your compositor and DE to say that it is as good as or better than the prior stable release.
    • If there is already a comment describing your environment, instead of posting a duplicate, please give it a thumbs-up reaction to "vote" for it if it is working well for you.
    • If it isn't working working as well or better than the prior stable release, please reference an issue that describes the problem and comment below.
  • Verify that the default configuration doesn't crash out.

    • Run wezterm -n on your system to launch it without your config. Does it successfully launch and display text with no artifacts or blocks for glyphs?
    • If not:
      • try changing the front_end setting to see if that is better:
      • wezterm -n --config "front_end='WebGpu'"
      • Please find/file an issue reporting the outcome of both the default and webgpu, along with information about the environment. If the behavior is a regression since the prior stable release, reference that issue here.
  • Confirm that we're building for the current batch of OS/distros

  • Other misc issues:

@wez wez added the enhancement New feature or request label Oct 31, 2024
@wez wez pinned this issue Oct 31, 2024
@rootiest
Copy link

rootiest commented Oct 31, 2024

KDE Plasma 6 (Wayland) working great for me on nightly.

@jankatins
Copy link
Contributor

jankatins commented Oct 31, 2024

I'm on Gnome 46/Mutter with Windowing system Wayland (fedora 40 workstation, up to date until yesterday), using wezterm 20241027_002434_14ad1937.

Stuff which I "notice" (I seem to remember that it worked sometime before the rewrite or when I was still on macosx). This is all with config.enable_wayland = true or not having that config set at all:

If I run with config.enable_wayland = false, I have a (grey, like the rest of GNOME) additional title bar with a single close button, I can move the window around, even when I was in fullscreen, it starts in full screen, and the window overflow problem is also gone.

So all in all: Using config.window_decorations = "INTEGRATED_BUTTONS" and some additional config.window_padding = {...} I can live with using wezterm (with config.enable_wayland = true) as my daily driver, but I'm also currently embarrassed to show my terminal window to colleagues who use warp or alacritty or recommend it to ppl. who would usually benefit from a cross platform terminal :-(

Relevant Gnome config:

gsettings set org.gnome.desktop.wm.keybindings maximize "['<Super>Up']"
gsettings set org.gnome.desktop.wm.preferences action-double-click-titlebar 'toggle-maximize'

@F5T3
Copy link

F5T3 commented Oct 31, 2024

wezterm-git (20241030.215404.f847bd28-1)
on
Hyprland (v0.44.0-73-g3cec45d8)
on
Arch Linux (Kernerls: linux [6.11.5-arch1-1], linux-lts [6.6.58-1] and linux-zen [6.11.5.zen1-1])

Output from running "wezterm" on kitty and having wayland support off:

22:58:46.242  ERROR  wezterm_client::client > IncompatibleVersionError { version: "20240203-110809-5046fc22", codec_vers: 42 }
22:58:46.259  WARN   window::os::wayland::connection > Unable to resolve appearance using xdg-desktop-portal: get_appearance.read_setting: Reading xdg-portal org.freedesktop.appearance color-scheme: org.freedesktop.DBus.Error.UnknownMethod: No such interface “org.freedesktop.portal.Settings” on object at path /org/freedesktop/portal/desktop

With wayland support on:

23:08:08.738  WARN   window::os::wayland::connection > Unable to resolve appearance using xdg-desktop-portal: get_appearance.read_setting: Reading xdg-portal org.freedesktop.appearance color-scheme: org.freedesktop.DBus.Error.UnknownMethod: No such interface “org.freedesktop.portal.Settings” on object at path /org/freedesktop/portal/desktop

@nekowinston
Copy link
Contributor

nekowinston commented Oct 31, 2024

There's a regression on Sway 1.10.
Nightly works for me on Sway 1.9, but I'm guessing the new wlroots-0.18 in 1.10 broke parts of the WezTerm Wayland implementation.

WezTerm stable WezTerm nightly (f847bd28)
Sway 1.9 Logs Logs
Sway 1.10 Logs Logs

Tested on NixOS unstable, Linux 6.11.5, x86_64-linux.

All logs are collected via:

WAYLAND_DEBUG=1 WEZTERM_LOG=window::os::wayland=trace cargo r --release --bin wezterm-gui -- -n --config "front_end='WebGpu'"

It's worth mentioning that [email protected] initially renders blurry text, which goes away after scaling/moving/maximizing the window once. But overall, I had a pretty reliable experience on Wayland on Sway 1.9.


As for Sway 1.10:

I've tried to chase down the error with a debug build & debugging via CodeLLDB, all I could gather from it, is that it crashes around here.
It seems to crash after a few iterations, so it makes debugging a bit frustrating; I'm happy to dive back in tho.
Sometimes it also doesn't crash, but "hangs", in that it logs loading the config, and rendering the cursor block etc, but simply won't render the terminal window. I'd say that happens on about 1/4th(?) of the launches.

@dani162
Copy link

dani162 commented Nov 1, 2024

wezterm 20241031_235112_0983ae90
Fedora 41 - Gnome 47 - Wayland

  • I would say the current nightly is much more stable than the current release (the current release wont even start anymore on my system). I am having the following issue with the current release, seems to be fixed in nightly. Weird issue when using wezterm on gnome wayland #6191
    I remember switching to the nightly version, because the release version kept on crashing all the time (Probably this was also related to fractional scaling)

Probably Regressions:

  • WezTerm behaves a bit buggy with fractional scaling enabled. When I open WezTerm on my Primary Monitor (150% Scaling, 3840x2160 Resolution) Wezterm has no icon in the dock where the open apps are displayed and is shown as Unknown Application. If i open WezTerm on my secondary Monitor (100% Scaling, 1920x1080 Resolution) it works fine.
    image
    Screenshot of Gnome Looking Glass Debug Tool (Alt + F2 - type lg). The First Application is WezTerm on the Monitor without Fractional Scaling, Second with Fractional Scaling (150%). I noticed that when opening the app, the icon is correct for a short time, but WezTerm immediately closes and reopens, only that the icon no longer works. This, closing and reopening behavior also happens if i move the Terminal from one Screen to the other and change focus to another window (it closes and reopens on the monitor on which my mouse is located at the time).
    WezTerm has no icon under Wayland when using fractional scaling (fractional-scale-v1) #6081
    I don't remember that happening in the last release, but i can not verify that anymore, because the current release is not starting anymore on my system.

  • When using config.window_decorations = “RESIZE” with a high dpi screen, the client-side window decorations do not match the size of the terminal (at least with Gnome, which does not implement server-side window decorations). Also, every time the window loses or gains focus, the window changes size.
    Wezterm creates crazy large window on Wayland in Fedora 40 #5360. Also don't remember this happening in the last release.

@wez
Copy link
Owner Author

wez commented Nov 2, 2024

Thanks for commenting folks. From a triage perspective, what I care about here in the context of this issue is:

  • Would releasing nightly now be worse than the prior stable release?

I don't want this issue to an umbrella for current bugs: those can all continue to live in the issue tracker.

So please review the comments you have made and if the issues are also present in the prior stable release, please edit your comments to elide that information from here.

I want to use this issue as a point of triage for getting wezterm-regressions-in-behavior-vs-its-last-stable-release resolved, and if it just duplicates general bugs it is not helpful.

Thank you!

@RomanAverin
Copy link

RomanAverin commented Nov 2, 2024

wezterm 20241031_235112_0983ae90
Fedora 41 - Gnome 47.1 - Mutter 47.1 - Wayland

  • From what I feel the night version is a bit more stable(less crash), but in terms of UI it is a clear regression compared to the last release version 20240203_110809_5046fc22. Window resizing doesn't work in the night version as part of the regression.

Screenshot From 2024-11-02 12-44-50

Screenshot From 2024-11-02 12-45-59

config.animation_fps = 60
config.front_end = "WebGpu"
config.window_decorations = "INTEGRATED_BUTTONS"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants