Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Select Mode includes tokens surrounding a URL #6319

Open
antoson opened this issue Oct 24, 2024 · 0 comments
Open

Quick Select Mode includes tokens surrounding a URL #6319

antoson opened this issue Oct 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@antoson
Copy link

antoson commented Oct 24, 2024

What Operating System(s) are you seeing this problem on?

Linux Wayland

Which Wayland compositor or X11 Window manager(s) are you using?

sway version 1.7

WezTerm version

20241015-083151-9ddca7bd

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

Quick Select Mode (QSM) is one of my favorite features of wezterm, thank you for it.

I discovered that it often includes characters that are not meant to be part of the URL. For example, URLs are often wrapped in parenthesis in docs.

In the image below from (man wlsunset), it shows how the parenthesis and the dot are included in the Quick Select output.

If I understood correctly, ) and . are valid tokens at the end of a URI: https://datatracker.ietf.org/doc/html/rfc3986#autoid-70 so is the issue related more to QSM not being able to distinguish inline URLs being placed in text without being separated by spaces?

I understand if solving this issue isn't feasible, but I am happy to help with testing otherwise. I can't code in Rust unfortunately.

To Reproduce

  1. echo "https://sr.ht/~kennylevinsen/wlsunset."
  2. echo "(https://xkcd.com/2170/)"
  3. Activate QSM Ctrl+Shift+Space

Configuration

no config

Expected Behavior

Quick Select Mode does not copy ) and . tokens

Logs

ondra:~/repos/wezterm$ cargo run --release --bin wezterm -- --skip-config start
    Finished `release` profile [optimized] target(s) in 0.30s
     Running `target/release/wezterm --skip-config start`
17:12:41.492  WARN   window::os::wayland::connection > Unable to resolve appearance using xdg-desktop-portal: get_appearance.read_setting: Reading xdg-portal org.freedesktop.appearance color-scheme: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.portal.Desktop was not provided by any .service files

Anything else?

qsm

@antoson antoson added the bug Something isn't working label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant