Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell* 需要继承 className #68

Closed
holymonson opened this issue Apr 22, 2016 · 2 comments
Closed

Cell* 需要继承 className #68

holymonson opened this issue Apr 22, 2016 · 2 comments

Comments

@holymonson
Copy link
Contributor

Label是继承 className

        const { className, children, ...others } = this.props;
        const cls = classNames({
            weui_label: true,
            [className]: className
        });

但像CellFooter之类的,className归入others了,会覆盖掉weui的类。

        const {children, ...others} = this.props;
        const className = classNames({
            weui_cell_ft: true
        });

希望统一改成前者,因为我们有时会需要自己加个类来微调下weui的。感谢!

@progrape
Copy link
Collaborator

感谢反馈,这个小需求可以接受 PR,或者等我稍后有空再改~

@progrape
Copy link
Collaborator

#51 顺便把这个也加上

progrape added a commit that referenced this issue Apr 28, 2016
* #58, patched searchbar, add iconSize for toast #62, change weui dependency to 0.4.1 (#63)

* update `weui` version

* update react version and move to peerDependencies (#66)

1. react 升级到 v15,并且引入了新的版本规范。
    @see https://facebook.github.io/react/blog/2016/02/19/new-versioning-scheme.html

2. 不同版本的 react 会冲突,把依赖写到 peerDependencies 更合适一点。参考其他
    react 相关的库,如 react-redux.

* fix extra comma in package.json

* 修复 package.son 依赖
1. 补充依赖 jsdom
2. npm 对依赖 history 顺序做了调整

* #68 Cell* 增加支持传入自定义 className

* #51 ActionSheet 的 menus 和 actions 增加支持传入自定义 className
@n7best n7best closed this as completed May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants