fix: missing imports with pydrive #23
Conversation
* leave in setuptools and its dependencies for pydrive and google-drive-python-api * pin httplib2 to v0.15.0 to fix pydrive issue
| # Clean up | ||
| && python3 -m pip uninstall -y pip pipenv setuptools \ | ||
| && apk del --purge .build-deps | ||
| && pipenv install --system --deploy |
There was a problem hiding this comment.
This image is meant to remain as small as possible and build dependencies are files that shouldn't be necessary at runtime. Please keep them.
There was a problem hiding this comment.
In some cases they are necessary: https://stackoverflow.com/questions/7446187/no-module-named-pkg-resources
There was a problem hiding this comment.
We could try leaving in only setuptools though. I don't recall if I tried that or if that caused issues. It was simpler to not remove things that may break the functionality, especially since this repo has no integration tests.
There was a problem hiding this comment.
Keeping the image from being broken is more important than it being small, I assumed :)
| @@ -34,6 +31,7 @@ pydrive = "*" | |||
| #pyrax = "*" | |||
| python-swiftclient = "*" | |||
| requests_oauthlib = "*" | |||
| httplib2 = "==0.15.0" | |||
There was a problem hiding this comment.
Why pin to this exact version? If required then please comment in the code about why.
There was a problem hiding this comment.
It's been so long since I worked on this I don't recall. I ended up writing my own image instead and don't have time to work on it. Feel free to close the issue and MR.
There was a problem hiding this comment.
I've merged some of your changes, thanks for the PR though.
Resolves #22
and google-drive-python-api