Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flake8-isort max version to 5 #1543

Closed
webknjaz opened this issue Aug 9, 2020 · 2 comments
Closed

Bump flake8-isort max version to 5 #1543

webknjaz opened this issue Aug 9, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@webknjaz
Copy link
Contributor

webknjaz commented Aug 9, 2020

This is basically a follow-up for #1500.

According to gforcada/flake8-isort#92 (comment), flake8-isort==4.0.0a0 is the first version to implement the compatibility with isort>=5.

They encourage everyone to battle-test the pre-release and a few folks have already reported it working well.

It's time to relax the upper bound of the dependency in this project so that it's possible to pull-in the fixed version of the library. (while in alpha, folks will still have to opt-in to install a pre-release explicitly in their deps)

@webknjaz webknjaz added the bug Something isn't working label Aug 9, 2020
@Dreamsorcerer
Copy link
Contributor

Looks like this has already been done on master: 451c8d1

@sobolevn
Copy link
Member

Yes! 👍

@sobolevn sobolevn reopened this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants