Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning #504

Open
arybczak opened this issue Dec 4, 2023 · 3 comments
Open

Versioning #504

arybczak opened this issue Dec 4, 2023 · 3 comments

Comments

@arybczak
Copy link
Collaborator

arybczak commented Dec 4, 2023

Looks like minor version of optics-core (0.4.1) is now behind optics (0.4.2) and optics-extra (0.4.2) 🤔

How do we get that under control? Should we skip 0.4.2 for optics-core and go directly to 0.4.3 with all?

@phadej
Copy link
Contributor

phadej commented Dec 4, 2023

#312 (comment) I also explained this kind of out-sync situation in #312 (comment) but neither you nor @adamgundry have responded to that, so I'm not sure what we agreed to do, if anything at all.

How do we get that under control? Should we skip 0.4.2 for optics-core and go directly to 0.4.3 with all?

optics-core release forces optics release, but it doesn't force optics-extra release. In my opinion re-releasing a package version with another version without any changes is not great.

But if there is desire to keep versions aligned, then there could be optics-core-0.4.3 and optics-0.4.3 releases, and optics-extra "lagging" at 0.4.2 (the same way as optics-core is lagging now).


TL;DR my proposed policy is "if you don't have anything to mention in the changelog, you shouldn't make a release either".

@arybczak
Copy link
Collaborator Author

arybczak commented Dec 5, 2023

there could be optics-core-0.4.3 and optics-0.4.3 releases, and optics-extra "lagging" at 0.4.2 (the same way as optics-core is lagging now).

Looks like a good solution to me 👍

@adamgundry
Copy link
Member

This sounds like a good approach to me too. So we don't re-release unchanged packages (relax bounds instead), but when we are making a release we skip intermediate minor versions to keep things aligned as much as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants