From 6fe6437ac8a0a69a101f71bda7358d4d6e3ac694 Mon Sep 17 00:00:00 2001 From: bors Date: Sat, 21 Jan 2023 21:15:35 +0000 Subject: [PATCH] Auto merge of #11610 - ehuss:disable-public-network-windows, r=epage Disable network SSH tests on windows. These tests have a high failure rate on Windows, so this disables them for now. I don't know exactly why they are failing. If I had to take a wild guess, I would suspect the use of WinCNG for the SSH backend, which may mean it is out of our control. --- tests/testsuite/ssh.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/testsuite/ssh.rs b/tests/testsuite/ssh.rs index b0fe9ffff63..e8f5ce7556c 100644 --- a/tests/testsuite/ssh.rs +++ b/tests/testsuite/ssh.rs @@ -386,6 +386,10 @@ Caused by: } #[cargo_test(public_network_test)] +// For unknown reasons, this test occasionally fails on Windows with a +// LIBSSH2_ERROR_KEY_EXCHANGE_FAILURE error: +// failed to start SSH session: Unable to exchange encryption keys; class=Ssh (23) +#[cfg_attr(windows, ignore = "test is flaky on windows")] fn invalid_github_key() { // A key for github.com in known_hosts should override the built-in key. // This uses a bogus key which should result in an error. @@ -417,6 +421,10 @@ fn invalid_github_key() { } #[cargo_test(public_network_test)] +// For unknown reasons, this test occasionally fails on Windows with a +// LIBSSH2_ERROR_KEY_EXCHANGE_FAILURE error: +// failed to start SSH session: Unable to exchange encryption keys; class=Ssh (23) +#[cfg_attr(windows, ignore = "test is flaky on windows")] fn bundled_github_works() { // The bundled key for github.com works. //