Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Vuetify ESLint rules. #322

Closed
fschmenger opened this issue Mar 13, 2023 · 4 comments
Closed

Enforce Vuetify ESLint rules. #322

fschmenger opened this issue Mar 13, 2023 · 4 comments

Comments

@fschmenger
Copy link
Collaborator

As proposed within #312, we should consider installing the plugin eslint-plugin-vuetify to have access to the Vuetify ESLint rules. This should help us in maintaining vuetify code and prevent us from using outdated components, properties etc.

@sronveaux
Copy link
Collaborator

Hi @fschmenger,

Indeed I was planning to work on this but waited for the Wegue V2 branch to become a reality as all the PRs I've written until now are unfortunately not independent but cumulative. V2 was branched from master, then V3 was branched from V2, V4 from V3 and eventually V5 from V4.

The eslint-plugin-vuetify require ESLint7 or ESLint8 and support of ESLint7 was only added in Vue-CLI V5. It means working on it now would add a new level of dependency. So I'd like to tackle this once we have a branch including Vue-CLI V5.

I'd propose to do two or three linked things here:

  1. Include the official Vuetify plugin for Vue-CLI
  2. Include and enforce the Vuetify ESLint rules
  3. Update ESLint from V7 to V8

The last point can be done separately but should be useful to get up-to-date on this subject.
ESLint8 was not compatible with Vue-CLI V4 but works well with Vue-CLI V5 so I definitely have to give it a try!

@fschmenger
Copy link
Collaborator Author

OK, thank you for pointing out the implications! I fully agree that we should put it on hold until #314 is finalized, as this will possibly result in a bunch of code formatting changes again. Again this isn`t urgent, so take your time!

@sronveaux
Copy link
Collaborator

Hi @fschmenger,

This was addressed by #348 and #355.
Except if you think of something else, this one can be closed...

@fschmenger
Copy link
Collaborator Author

Hi Sebastien, thanks a lot for implementing this and thanks to Christian as well for testing.
Sorry for being so quiet lately as Im still very limited on time. Anyway Im closing this issue for now.
Cheers Felix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants