Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for lockfileVersion 3 #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Airdevelopments
Copy link

This might be handy for people who updated from an old lockfileVersion 1 to lockfileVersion 3 immediately (skipping lockfileVersion 2).

Requesting a review of the changes, since I am not really certain of the differences between lockfileVersion 2 and 3.

@webstech
Copy link
Owner

webstech commented May 5, 2023

This might be handy for people who updated from an old lockfileVersion 1 to lockfileVersion 3 immediately (skipping lockfileVersion 2).

On what version of npm did you find this problem? I ran a test on npm 9.1.1 and it set hasInstallScript during auto-upgrade of the lockfile from v1 to v3.

Requesting a review of the changes, since I am not really certain of the differences between lockfileVersion 2 and 3.

From the doc, v2 is a compatibility format containing both the v1 and v3 information.

@Airdevelopments
Copy link
Author

It was one of the recent npm versions (9.6.5 I think.). It only involved packages from 3rd party package registries using authentication (fontawesome and an internal one via gitlab).

We updated from node 14 to 18 and npm 5 or 6 to 9 (and the lockfiles with that).

Packages like electron via the public npm registry did not run into any issues adding the install scripts flag to the lockfile.

I will try to create a small repo to reproduce the issue if necessary (but might take a week or two since I don't have the time available rn).

Thank you for answering the pull request.

Best Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants