Add check for error type (#8)

* Add check for error instanceof error

* Regenerate client with new error

* Add ts check to tests

* Regenearte client contract with v0.11

* Fix ts-check in pipline

* Remove wrong tsc package

Author: AlexanderKolberg

.github/workflows/ci.yml

@@ -32,7 +32,7 @@ jobs:
       - name: Git diff of regenerated files
         run: cd _examples && make diff
 
-  webrpc-interoperability:
+  webrpc-tests:
     strategy:
       matrix:
         webrpc-version: [v0.11.0]
@@ -55,3 +55,5 @@ jobs:
         run: cd tests && echo "$PWD/bin/${{ matrix.webrpc-version }}" >> $GITHUB_PATH
       - name: Run interoperability tests
         run: cd tests && ./test.sh
+      - name: Run typescript check
+        run: cd tests && npm run ts-check

_examples/node-ts/webapp/client.gen.ts

@@ -119,9 +119,13 @@ const buildResponse = (res: Response): Promise<any> => {
     try {
       data = JSON.parse(text)
     } catch(error) {
+      let message = ''
+      if (error instanceof Error)  {
+        message = error.message
+      }
       throw WebrpcBadResponseError.new({
         status: res.status,
-        cause: `JSON.parse(): ${error.message || ''}: response text: ${text}`},
+        cause: `JSON.parse(): ${message}: response text: ${text}`},
       )
     }
     if (!res.ok) {

clientHelpers.go.tmpl

@@ -16,9 +16,13 @@ const buildResponse = (res: Response): Promise<any> => {
     try {
       data = JSON.parse(text)
     } catch(error) {
+      let message = ''
+      if (error instanceof Error)  {
+        message = error.message
+      }
       throw WebrpcBadResponseError.new({
         status: res.status,
-        cause: `JSON.parse(): ${error.message || ''}: response text: ${text}`},
+        cause: `JSON.parse(): ${message}: response text: ${text}`},
       )
     }
     if (!res.ok) {

tests/package-lock.json

@@ -5,7 +5,9 @@
   "main": "index.js",
   "scripts": {
     "test": "./test.sh",
-    "vitest": "./node_modules/.bin/vitest run --reporter verbose --dir ./"
+    "vitest": "./node_modules/.bin/vitest run --reporter verbose --dir ./",
+    "prets-check": "webrpc-gen -schema=./test.ridl -target=../ -client -out=./client.ts",
+    "ts-check": "tsc --noEmit ./client.ts"
   },
   "repository": {
     "type": "git",
@@ -18,6 +20,7 @@
   },
   "homepage": "https://github.com/webrpc/gen-typescript#readme",
   "devDependencies": {
+    "typescript": "^5.1.6",
     "vitest": "^0.25.6"
   },
   "engines": {