Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testID prop #103

Closed
oikalyptus opened this issue Apr 24, 2023 · 3 comments
Closed

Add testID prop #103

oikalyptus opened this issue Apr 24, 2023 · 3 comments

Comments

@oikalyptus
Copy link

Please add the possibility to set a testID.
I could submit a PR if you give me the permission.
@webraptor
Copy link
Owner

That would be awesome! We could put a general testId for the swiper and a dynamic one for each rendered card. But that can also be done through the card content.

If you do submit a PR please also bump the patch version.

Thanks

@oikalyptus
Copy link
Author

oikalyptus commented May 16, 2023 •
edited
Loading

Hey @webraptor,

My PR has been open for 3 weeks now. Let me know if you want me to change anything.

@webraptor
Copy link
Owner

Completely forgot about it. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webraptor @oikalyptus