Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives being reported on two packages #707

Closed
jonahallibone opened this issue Jun 27, 2024 · 2 comments
Closed

False positives being reported on two packages #707

jonahallibone opened this issue Jun 27, 2024 · 2 comments
Labels
regression Something is no longer working

Comments

@jonahallibone
Copy link

Until yesterday, my repository correctly listed no unused dependencies.

SInce the release, I am getting this report:

Screenshot 2024-06-27 at 4 03 37 PM

Nothing with these files changed, nor did any dependencies other than knip change.

I am using a next.js project in a monorepo. Here is my config:

{
  "workspaces": {
    "frontend": {
      "ignore": [
        "src/hooks/general/use-interval.ts",
        "src/scripts/generate-types.ts",
        "tests/**",
        "./api",
        "./empty-module.ts"
      ],
      "ignoreDependencies": [
        "@hookform/devtools",
        "styles/*",
        "prosemirror-*",
        "puppeteer",
        "./api"
      ]
    }
  }
}

It is run in github actions via

npx knip --production --dependencies --include files --exclude unlisted,unresolved --reporter markdown
@jonahallibone jonahallibone added the bug Something isn't working label Jun 27, 2024
@webpro
Copy link
Collaborator

webpro commented Jun 27, 2024

Of course there can be a regression. But sometimes a fix in a lib seemingly "breaks" things for you. What's the exact version that degrades behavior in your case?

Please read https://knip.dev/guides/issue-reproduction.

Apart from the issue reported, what I can say from this configuration is that you probably want to read up on https://knip.dev/guides/configuring-project-files

@webpro webpro added regression Something is no longer working and removed bug Something isn't working labels Jun 27, 2024
@webpro
Copy link
Collaborator

webpro commented Jul 16, 2024

Closing due to inactivity. Feel free to open a new issue with an actionable reproduction.

@webpro webpro closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Something is no longer working
Projects
None yet
Development

No branches or pull requests

2 participants