Housekeep isInForIteration heuristic

Author: webpro

packages/knip/fixtures/import-star-iteration/package.json

@@ -1,17 +1,3 @@
 {
-  "name": "@fixtures/import-star-iteration",
-  "devDependencies": {
-    "ts-node": "^10.8.2"
-  },
-  "scripts": {
-    "execute-test-code": "ts-node index.ts"
-  },
-  "knip": {
-    "ignoreBinaries": [
-      "ts-node"
-    ],
-    "ignoreDependencies": [
-      "ts-node"
-    ]
-  }
+  "name": "@fixtures/import-star-iteration"
 }

packages/knip/src/typescript/ast-helpers.ts

@@ -165,11 +165,6 @@ export const isDestructuring = (node: ts.Node) =>
   ts.isVariableDeclarationList(node.parent.parent) &&
   ts.isObjectBindingPattern(node.parent.name);
 
-// Pattern: for (const x in NS) { }
-// Pattern: for (const x of NS) { }
-export const isIteratingObject = (node: ts.Node) =>
-  node.parent && (ts.isForInStatement(node.parent) || ts.isForOfStatement(node.parent));
-
 export const getDestructuredIds = (name: ts.ObjectBindingPattern) =>
   name.elements.map(element => element.name.getText());
 
@@ -192,6 +187,9 @@ export const isObjectEnumerationCallExpressionArgument = (node: ts.Identifier) =
   node.parent.expression.expression.escapedText === 'Object' &&
   objectEnumerationMethods.has(String(node.parent.expression.name.escapedText));
 
+export const isInForIteration = (node: ts.Node) =>
+  node.parent && (ts.isForInStatement(node.parent) || ts.isForOfStatement(node.parent));
+
 export const isTopLevel = (node: ts.Node) =>
   ts.isSourceFile(node.parent) || (node.parent && ts.isSourceFile(node.parent.parent));
 

packages/knip/src/typescript/get-imports-and-exports.ts

@@ -22,7 +22,7 @@ import {
   isConsiderReferencedNS,
   isDestructuring,
   isImportSpecifier,
-  isIteratingObject,
+  isInForIteration,
   isObjectEnumerationCallExpressionArgument,
   isReferencedInExport,
 } from './ast-helpers.js';
@@ -354,7 +354,7 @@ const getImportsAndExports = (
                 } else if (isObjectEnumerationCallExpressionArgument(node)) {
                   // Pattern: Object.keys(NS)
                   imports.refs.add(id);
-                } else if (isIteratingObject(node)) {
+                } else if (isInForIteration(node)) {
                   // Pattern: for (const x in NS) { }
                   // Pattern: for (const x of NS) { }
                   imports.refs.add(id);