Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack is breaking npm ssh2 module #3332

Closed
renegadeandy opened this issue Nov 18, 2016 · 6 comments
Closed

Webpack is breaking npm ssh2 module #3332

renegadeandy opened this issue Nov 18, 2016 · 6 comments

Comments

@renegadeandy
Copy link

Hi,

I want to use the ssh2 pack from https://www.npmjs.com/package/ssh2 in my Electron app inside an angular 2 service.

I found that it didn't work out the box - which was strange because all other npm packages just 'worked' including an FTP module.

I come here after this stack overflow post, and a followup issue on the ssh2 package github :

http://stackoverflow.com/questions/40646733/using-npm-package-ssh2-within-an-angular2-application-running-under-electron?noredirect=1#comment68563936_40646733

And this ssh2 issue:

mscdex/ssh2#502

The ssh2 package maintainer suggested I added an issue here to see if you guys on the webpack side can help at all, because I think he has run out of ideas on what he can do to fix it.

Any and all support would be very graciously received.

@SpaceK33z
Copy link
Member

Okay so the issue is our implementation of the EventEmitter is not as expected. The package node-libs-browser provides those polyfills. You could make an issue there, or add a comment to webpack/node-libs-browser#44. It seems like there are more problems with that implementation.

@mscdex
Copy link

mscdex commented Nov 20, 2016

I'm not sure I'm convinced that's the issue. I looked into it and the current EventEmitter implementation used by node-libs-browser has included return this in its .on() implementation ever since its first release back in 2011. node-libs-browser has used that same EventEmitter implementation since node-libs-browser v0.5.0 (released in March 2014) and before that it used its own in-house implementation which still had return this in its .on() implementation.

This is what has me confused. With all of this evidence I cannot see how it is possible for .on() to return undefined.

@renegadeandy
Copy link
Author

Why is this issue closed - it is not fixed!

@SpaceK33z
Copy link
Member

Please provide more information to confirm that this is really a webpack bug.

@renegadeandy
Copy link
Author

What would you like from me!

@renegadeandy
Copy link
Author

@mscdex maybe you can help here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants