Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency ws to v7 #1834

Merged
merged 2 commits into from
Jun 5, 2019
Merged

chore(deps): update dependency ws to v7 #1834

merged 2 commits into from
Jun 5, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 30, 2019

This PR contains the following updates:

Package Type Update Change
ws devDependencies major ^6.2.1 -> ^7.0.0

Release Notes

websockets/ws

v7.0.0

Compare Source

Breaking changes

  • Dropped support for Node.js 6 (1e6999b).
  • Dropped support for url.Url instances in the WebSocket constructor
    (692d7b4).
  • The behavior of WebSocket#{p{i,o}ng,send}() has changed when the
    readyState attribute is not OPEN (#​1532)
    • If the readyState attribute is CONNECTING, an exception is thrown.
    • If the readyState attribute is CLOSING or CLOSED
      • The bufferedAmount attribute is increased by the length of the data
        argument in bytes.
      • If provided, the callback function is called with an error.
      • No exception is thrown even if the callback function is not provided.

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@hiroppy
Copy link
Member

hiroppy commented Apr 30, 2019

ws seems to be supported over v8.

  /home/travis/build/webpack/webpack-dev-server/node_modules/ws/lib/websocket.js:369
          ...options
          ^^^
    SyntaxError: Unexpected token ...
      at ScriptTransformer._transformAndBuildScript (node_modules/@jest/transform/build/ScriptTransformer.js:471:17)
      at ScriptTransformer.transform (node_modules/@jest/transform/build/ScriptTransformer.js:513:25)
      at Object.<anonymous> (node_modules/ws/index.js:3:19)

BTW, I want to drop Node6. (because it will be End-of-Life on 30th April)

@evilebottnawi What do you think?

@alexander-akait
Copy link
Member

Yes i think we can do this

@alexander-akait
Copy link
Member

But before i think we should fix popular bugs and popular feature requests

@renovate renovate bot force-pushed the renovate/ws-7.x branch from eaff3d5 to 25288d4 Compare May 2, 2019 13:33
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #1834 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1834   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          28       28           
  Lines        1060     1060           
  Branches      322      322           
=======================================
  Hits          979      979           
  Misses         77       77           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d2dff...602d56d. Read the comment docs.

@renovate renovate bot force-pushed the renovate/ws-7.x branch 11 times, most recently from 5e2701e to ad95d88 Compare May 10, 2019 18:37
@renovate renovate bot force-pushed the renovate/ws-7.x branch 9 times, most recently from f09d853 to 7213e1f Compare May 15, 2019 14:39
@renovate renovate bot force-pushed the renovate/ws-7.x branch 5 times, most recently from 276c35e to 79a268d Compare June 5, 2019 13:43
@renovate renovate bot force-pushed the renovate/ws-7.x branch from 79a268d to ba7015d Compare June 5, 2019 16:41
@hiroppy hiroppy changed the base branch from master to next June 5, 2019 18:42
@renovate
Copy link
Contributor Author

renovate bot commented Jun 5, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@hiroppy hiroppy merged commit b7bd5c6 into next Jun 5, 2019
@hiroppy hiroppy deleted the renovate/ws-7.x branch June 5, 2019 19:48
hiroppy pushed a commit that referenced this pull request Jun 7, 2019
knagaitsev pushed a commit to knagaitsev/webpack-dev-server that referenced this pull request Jul 31, 2019
hiroppy pushed a commit that referenced this pull request Aug 1, 2019
hiroppy pushed a commit that referenced this pull request Aug 2, 2019
hiroppy pushed a commit that referenced this pull request Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants