fix: respect https.cacert option - #3820
Merged
Merged
Conversation
alexander-akait
marked this pull request as ready for review
September 9, 2021 11:19
alexander-akait
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
September 9, 2021 11:19
Contributor
Author
|
Let's add |
Codecov Report
@@ Coverage Diff @@
## master #3820 +/- ##
==========================================
- Coverage 92.80% 92.72% -0.09%
==========================================
Files 14 14
Lines 1321 1333 +12
Branches 463 470 +7
==========================================
+ Hits 1226 1236 +10
- Misses 87 89 +2
Partials 8 8
Continue to review full report at Codecov.
|
Member
|
I will finish PR, here some more work |
snitin315
commented
Sep 9, 2021
Member
|
@snitin315 Need documented after merge:
|
Contributor
Author
|
@alexander-akait I will take care of documentation 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No
Motivation / Use-Case
Fix #3814
Breaking Changes
None
Additional Info
https://nodejs.org/api/tls.html#tls_tls_createsecurecontext_options