fix: respect infastructureLogging.level for client.logging - #3613
Merged
Conversation
6 tasks
snitin315
force-pushed
the
respect-infrastructure-logging
branch
from
August 11, 2021 11:08
978dca5 to
f5c319c
Compare
|
|
||
| options.client.logging = | ||
| configWithInfrastructureLogging.infrastructureLogging.level; | ||
| } |
Member
There was a problem hiding this comment.
I think we need better logic here, ideally we should get options from compiler where we found devServer options
alexander-akait
force-pushed
the
respect-infrastructure-logging
branch
from
August 15, 2021 19:11
d3c2cf5 to
823420b
Compare
alexander-akait
marked this pull request as ready for review
August 15, 2021 19:11
alexander-akait
requested review from
anshumanv,
hiroppy and
knagaitsev
as code owners
August 15, 2021 19:11
Member
|
WIP on tests |
Member
|
Also refactor other weird cases |
alexander-akait
force-pushed
the
respect-infrastructure-logging
branch
from
August 16, 2021 11:29
b15273a to
cda3ec1
Compare
Codecov Report
@@ Coverage Diff @@
## master #3613 +/- ##
==========================================
- Coverage 93.87% 93.58% -0.30%
==========================================
Files 15 15
Lines 1290 1294 +4
Branches 443 446 +3
==========================================
Hits 1211 1211
- Misses 72 76 +4
Partials 7 7
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
Fix #2889
Breaking Changes
None
Additional Info
No