feat: add option to close overlay - #3433
Merged
Merged
Conversation
anshumanv
requested review from
alexander-akait,
hiroppy,
knagaitsev and
snitin315
as code owners
June 13, 2021 11:47
snitin315
reviewed
Jun 13, 2021
anshumanv
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3433 +/- ##
==========================================
- Coverage 94.77% 94.28% -0.50%
==========================================
Files 34 33 -1
Lines 1360 1295 -65
Branches 403 400 -3
==========================================
- Hits 1289 1221 -68
- Misses 66 67 +1
- Partials 5 7 +2
Continue to review full report at Codecov.
|
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
Can we add e2e/overlay.test.js and add simple test?
Contributor
Author
|
yep lets add it |
Member
|
@anshumanv I will write one couple tests today, so in future you will easy to add them more |
Contributor
Author
|
yep big thanks @alexander-akait! |
Member
|
I'm tired of these tests, it is more stable right now, but still very flaky, 80% times of my time I spend on tests instead writing code |
alexander-akait
force-pushed
the
overlay-2
branch
from
June 17, 2021 18:48
ecefb30 to
b5fd6eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
yet to
Motivation / Use-Case
add a button on the error overlay to manually allow closing the overlay
Breaking Changes
no
Additional Info
fixes #3361