Refactor webpack-dev-server middleware application logic #5149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the middleware application logic in the webpack-dev-server codebase to ensure that middleware is applied only once, regardless of how many times it's called. Previously, certain middleware, such as static serving middleware, was being applied multiple times to support features like `historyApiFallback`. This refactor eliminates duplicate middleware application by introducing a mechanism to track applied middleware and applying each middleware only once. Changes: - Introduced `appliedMiddleware` array to track applied middleware. - Created `applyMiddlewareOnce` function to apply middleware only if it hasn't been applied before. - Updated webpack-dev-server codebase to utilize `applyMiddlewareOnce` for applying middleware associated with various features. This update aims to improve code efficiency and prevent unintended behavior or performance issues caused by duplicate middleware application. Fixes: webpack#2716
Swapnilden
requested review from
alexander-akait,
hiroppy,
snitin315 and
anshumanv
as code owners
alexander-akait
requested changes
Apr 11, 2024
lib/Server.js
Outdated
| applyMiddlewareOnce.call(this, proxyMiddleware); | ||
| } | ||
|
|
||
| if (this.options.contentBase !== false) { |
There was a problem hiding this comment.
We don't have contentBase anymore
In this updated version, I have included test cases to ensure that the applyMiddlewareOnce function behaves as expected. Additionally, I have removed references to contentBase, as requested.
Swapnilden
commented
Apr 11, 2024
lib/Server.js
Outdated
| expect(app.use).toHaveBeenCalledWith(middlewareFunction1); | ||
| expect(app.use).toHaveBeenCalledWith(middlewareFunction2); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
We should not store it here
There was a problem hiding this comment.
So please suggest for proceedings
There was a problem hiding this comment.
We have the test directory
There was a problem hiding this comment.
can you suggest me file name , it can be big help
There was a problem hiding this comment.
open-option.test.js or proxy-option.test.js
|
Closing due to inactivity. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the middleware application logic in the webpack-dev-server codebase to ensure that middleware is applied only once, regardless of how many times it's called.
Previously, certain middleware, such as static serving middleware, was being applied multiple times to support features like
historyApiFallback. This refactor eliminates duplicate middleware application by introducing a mechanism to track applied middleware and applying each middleware only once.Changes:
appliedMiddlewarearray to track applied middleware.applyMiddlewareOncefunction to apply middleware only if it hasn't been applied before.applyMiddlewareOncefor applying middleware associated with various features.This update aims to improve code efficiency and prevent unintended behavior or performance issues caused by duplicate middleware application.
Fixes: #2716
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Breaking Changes
Additional Info