feat: export initialized socket client (#4304)

webpack · Apr 5, 2022 · 7920364 · 7920364
1 parent 4e7800e
commit 7920364
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/client-src/socket.js b/client-src/socket.js
@@ -16,7 +16,11 @@ const Client =
 
 let retries = 0;
 let maxRetries = 10;
-let client = null;
+
+// Initialized client is exported so external consumers can utilize the same instance
+// It is mutable to enforce singleton
+// eslint-disable-next-line import/no-mutable-exports
+export let client = null;
 
 /**
  * @param {string} url

diff --git a/test/client/socket-helper.test.js b/test/client/socket-helper.test.js
@@ -5,7 +5,7 @@
 "use strict";
 
 describe("socket", () => {
-  afterEach(() => {
+  beforeEach(() => {
     jest.resetAllMocks();
     jest.resetModules();
   });
@@ -77,4 +77,19 @@ describe("socket", () => {
     expect(mockClientInstance.onMessage.mock.calls).toMatchSnapshot();
     expect(mockHandler.mock.calls).toMatchSnapshot();
   });
+
+  it("should export initialized client", () => {
+    const socket = require("../../client/socket").default;
+
+    const nonInitializedInstance = require("../../client/socket").client;
+    expect(nonInitializedInstance).toBe(null);
+
+    socket("my.url", {});
+
+    const initializedInstance = require("../../client/socket").client;
+    expect(initializedInstance).not.toBe(null);
+    expect(typeof initializedInstance.onClose).toBe("function");
+    expect(typeof initializedInstance.onMessage).toBe("function");
+    expect(typeof initializedInstance.onOpen).toBe("function");
+  });
 });