Skip to content

Commit 1bae63b

Browse files
fix: code
1 parent 08336a6 commit 1bae63b

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

lib/servers/SockJSServer.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,14 @@ module.exports = class SockJSServer extends BaseServer {
7474
});
7575
});
7676

77-
this.implementation.close = () => {
77+
this.implementation.close = (callback) => {
7878
for (const client of this.clients) {
7979
client.close();
8080
}
8181

8282
this.clients.clear();
83+
84+
callback();
8385
};
8486
}
8587
};

test/server/proxy-option.test.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ describe("proxy option", () => {
584584
ws = new WebSocket(`ws://localhost:${port3}/proxy3/socket`);
585585

586586
ws.on("message", (message) => {
587-
responseMessage = message;
587+
responseMessage = message.toString();
588588
done();
589589
});
590590

@@ -600,6 +600,10 @@ describe("proxy option", () => {
600600
afterAll(async () => {
601601
webSocketServer.close();
602602

603+
for (const client of webSocketServer.clients) {
604+
client.terminate();
605+
}
606+
603607
await server.stop();
604608
});
605609
});

test/server/setupExitSignals-option.test.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,12 @@ describe("setupExitSignals option", () => {
4646

4747
it.each(signals)("should close and exit on %s", (signal, done) => {
4848
process.emit(signal);
49-
process.nextTick(() => {
49+
50+
setTimeout(() => {
5051
expect(killSpy.mock.calls.length).toEqual(1);
52+
expect(exitSpy.mock.calls.length).toEqual(1);
5153

5254
done();
53-
});
55+
}, 1000);
5456
});
5557
});

0 commit comments

Comments
 (0)