Commit 3a75999
authored
Drop support for Node versions less than 16.20.2 (#650)
* Configure development node version to use v22.x
* Configure node version in package.json to require latest node 16.x LTS
* Update lockfiles after npm install with node v22.x
* Update babel and webpack packages, dropping support for Node.js < v16
* Update CI to run with node LTS v16.x and higher
Pin to older Ubuntu version in CI to avoid Puppeteer sandbox problem
Always run tests to completion with all Node versions, even if one fails
* Update tests and skip troublesome ones
The expected report sizes match what Node.js v18.x and higher are
returning. Node.js v16.x and lower have different gzip calculations.
Update expected report size to match reality
The troublesome skipped tests are likely those which have regressed in
the past but the regression wasn't caused by Node.js support change.
Testing Node.js v18.x on CI is skipped for now as tests hang there.
* Mention Node.js support drop as a breaking change
* Update test badges in README.md
* Try running Node.js v18.x in CI
* Revert "Try running Node.js v18.x in CI"
This reverts commit 377aa2b.
The test failure we are seeing in CI with Node.js v18.x is this:
FAIL test/viewer.js (5.081 s)
● WebSocket server › should not crash when an error is emitted on the websocket
connect ECONNREFUSED ::1:41847
● WebSocket server › should not crash when an error is emitted on the websocket
thrown: "Exceeded timeout of 5000 ms for a test while waiting for `done()` to be called.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
9 |
10 | describe('WebSocket server', function () {
> 11 | it('should not crash when an error is emitted on the websocket', function (done) {
| ^
12 | const bundleStats = {
13 | assets: [{name: 'bundle.js', chunks: [0]}]
14 | };
at it (test/viewer.js:11:3)
at Object.describe (test/viewer.js:10:1)
PASS test/Logger.js
PASS test/statsUtils.js
PASS test/utils.js
PASS test/parseUtils.js
PASS test/dev-server.js
Test Suites: 1 failed, 7 passed, 8 total
Tests: 1 failed, 4 skipped, 115 passed, 120 total
Snapshots: 0 total
Time: 18.536 s
Ran all test suites.
Jest did not exit one second after the test run has completed.
'This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue.1 parent b82e5fa commit 3a75999
File tree
18 files changed
+14574
-9456
lines changed- .github/workflows
- test
- stats
- webpack-5-bundle-with-concatenated-entry-module
- webpack-5-bundle-with-multiple-entries
- webpack-5-bundle-with-single-entry
- with-module-concatenation-info
- with-multiple-entrypoints
- with-special-chars
- webpack-versions
- 4.44.2
- 5.76.0
18 files changed
+14574
-9456
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 8 | | |
13 | 9 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | | - | |
12 | | - | |
13 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
14 | 22 | | |
15 | 23 | | |
16 | 24 | | |
17 | 25 | | |
18 | 26 | | |
19 | 27 | | |
20 | 28 | | |
21 | | - | |
| 29 | + | |
22 | 30 | | |
23 | 31 | | |
24 | 32 | | |
25 | 33 | | |
26 | 34 | | |
27 | | - | |
| 35 | + | |
28 | 36 | | |
29 | 37 | | |
30 | | - | |
| 38 | + | |
31 | 39 | | |
32 | 40 | | |
33 | 41 | | |
| |||
38 | 46 | | |
39 | 47 | | |
40 | 48 | | |
41 | | - | |
| 49 | + | |
42 | 50 | | |
43 | 51 | | |
44 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
15 | 19 | | |
16 | 20 | | |
17 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
213 | | - | |
214 | | - | |
| 213 | + | |
| 214 | + | |
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
| |||
0 commit comments