Update for test for old IE versions #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are either missed or have different set of properties (e.g. into test environments or into browser addons). Fixes #177
|
|
michael-ciniawsky
approved these changes
Mar 21, 2017
Member
|
@FlyingDR Does JSDOM work 😛 ? And please sign the CLA if it is buggy close and reopen the PR |
Contributor
Author
|
@michael-ciniawsky No idea about JSDOM, never had experience with it. Maybe @frodare can help with testing this change with JSDOM? |
bebraw
approved these changes
Mar 21, 2017
bebraw
left a comment
bebraw
left a comment
There was a problem hiding this comment.
I guess ideally we would figure out a way to run style-loader against Browserstack but that's another PR.
Member
|
@FlyingDR Alright nevermind then 😛 |
|
@FlyingDR this PR does fix the issue for our JSDOM testing environment. |
Member
|
@FlyingDR Thx 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix for #177
Did you add tests for your changes?
Change is only testable in a browsers, code itself was tested using Browserstack into whole range of IE versions across all versions of Windows starting from XP and into outdated / actual versions of all browsers on Windows / OS X / Android / iOS / Windows Phone.
If relevant, did you update the README?
Doesn't seems to be relevant
Summary
Test for old IE versions is updated to avoid blind accessing properties of global objects that may not be available into certain real environments (examples are here and here). Since the whole purpose of this test is about giving positive result for old IE versions (<=IE9) it can be safely updated with a test that is specifically targeted to these versions and doesn't tries to get deeper into (potentially missing) properties of globals.
Does this PR introduce a breaking change?
No