Conversation
- Make all source map paths relative to the entry file. This way we don't have to read the `context` option from the webpack config. - Fix source maps on Windows: node-sass returns POSIX paths, that's why we need to transform them back to native paths. This fixes an error on windows where the source-map module cannot resolve the source maps. See #366 (comment)
|
@bholloway this will again be breaking for the resolve-url-loader. I've created a PR for this: bholloway/resolve-url-loader#44 |
|
@jhnns Can you confirm that module imports (i.e. tilde I will try to reproduce with your |
|
@jhnns I have tweaked your The source code is in this gist. It requires you to install The overall output is of the form: {
"sources": [
"webpack:///webpack:///test/scss/bootstrap-sass.scss",
"webpack:///webpack:///test/scss/~/bootstrap-sass/assets/stylesheets/_bootstrap.scss"
...
]
...,
"sourceRoot": ""
}We can ignore the repeated I am less interested in the overall output and more interested in what goes into the The debug output from While this debug info does not include the (Please Note the |
All source map paths will be relative to process.cwd() from now on. This removes also the last dependency on this.options.context. node-sass source map options like sourceMapRoot, omitSourceMapUrl, sourceMapContents are now overridable. #374 (comment)
|
These source maps are truly driving me crazy ^^ Could you review #377 and try it with your test setup? I think, now all paths should be correct. |
Make all source map paths relative to the entry file. This way we don't have to read the
contextoption from the webpack config.Fix source maps on Windows: node-sass returns POSIX paths, that's why we need to transform them back to native paths. This fixes an error on windows where the source-map module cannot resolve the source maps.
See #366 (comment)