fixes issue #275 #277
Closed
fixes issue #275 #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I tried adding a failing test to this file, but kept getting |
Author
|
I went ahead and pushed the broken tests so you can take a look. At least when it fails, it fails hard ^_^ |
Member
|
Thx for pointing it out. I took the essential parts and created a new PR #281 |
Member
|
The segmentation fault is because one of the assertions inside the custom importer did not work. Unfortunately, node-sass is not reporting these errors to node. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change that fixes #275. Because the importer returned is now actually a proxy function, we needed to pass the context of the proxy to the real importer as some importers (such as
node-sass-import-once) rely on this.