Skip to content

Update deps #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhnns merged 1 commit into from
Nov 22, 2015
Merged

Update deps #182

jhnns merged 1 commit into from
Nov 22, 2015

Conversation

@chicoxyzzy
Copy link
Contributor

@chicoxyzzy chicoxyzzy commented Oct 27, 2015

@browniefed
Copy link

browniefed commented Oct 29, 2015

This would be great to get in!

@ChrisCinelli
Copy link

ChrisCinelli commented Nov 19, 2015

Node-sass : 3.4.2 - Please and please merge and realese =)

@chicoxyzzy
update deps
4d0b004 
- node-sass v3.4.2 (including libsass v3.3.2 with regression fixes)
- update other deps to last versions

- update tests according to new deps asserts
@chicoxyzzy
Copy link
Contributor Author

chicoxyzzy commented Nov 19, 2015

updated

  • node-sass 3.4.2
  • other deps
  • test asserts

@ChrisCinelli
Copy link

ChrisCinelli commented Nov 19, 2015

@jhnns, what do you think? Can we merge and release?
We had a problem with syntax that is fixed in libsass v3.3.2 -> Node-sass 3.4.2

@jhnns
Copy link
Member

jhnns commented Nov 20, 2015

Thx @chicoxyzzy. I'll merge it as soon as I've found some time.

@ChrisCinelli node-sass is a peerDependency. You should be able to bump the version in your project independently (as long as it is not a major version bump). That's why we've made it a peerDependency

jhnns added a commit that referenced this pull request Nov 22, 2015
@jhnns
Merge pull request #182 from chicoxyzzy/update-deps
66c87f0 
Update deps
@jhnns jhnns merged commit 66c87f0 into webpack:master Nov 22, 2015
@jhnns
Copy link
Member

jhnns commented Nov 22, 2015

Shipped with 3.1.2

@chicoxyzzy chicoxyzzy deleted the update-deps branch November 23, 2015 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chicoxyzzy @browniefed @ChrisCinelli @jhnns