Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concat directory separators instead of "/" to make it work on Windows… #40

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

Gohan
Copy link
Contributor

@Gohan Gohan commented Mar 29, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

bugfix for #39 #39

Motivation / Use-Case

Fix: windows platform dlopen path concat

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #40 (602c32b) into master (cd1e9c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           13        13           
  Branches         3         3           
=========================================
  Hits            13        13           
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd1e9c0...602c32b. Read the comment docs.

@alexander-akait alexander-akait merged commit 3eb7041 into webpack-contrib:master Apr 5, 2021
@alexander-akait
Copy link
Member

Thanks

@Gohan Gohan deleted the patch-1 branch April 5, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants