Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate absolute paths in filename #878

Merged
merged 1 commit into from
Dec 7, 2021
Merged

fix: validate absolute paths in filename #878

merged 1 commit into from
Dec 7, 2021

Conversation

anshumanv
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fix #877

Breaking Changes

No

Additional Info

Do not allow absolute paths in filename schema, add min length of 1.

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #878 (a60bde5) into master (e8c08a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #878   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files           6        6           
  Lines         792      792           
  Branches      214      214           
=======================================
  Hits          723      723           
  Misses         63       63           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8c08a1...a60bde5. Read the comment docs.

@alexander-akait
Copy link
Member

Thanks

@anshumanv anshumanv merged commit 76361df into master Dec 7, 2021
@anshumanv anshumanv deleted the 877 branch December 7, 2021 15:46
@anshumanv
Copy link
Member Author

@alexander-akait I realized there are more path options like chunkFilename and publicPath, should we add this check there too?

@alexander-akait
Copy link
Member

publicPath can be any, for chunkFilename - yes

@anshumanv
Copy link
Member Author

Got it, let me send a follow up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using a forward-slash in filename, the wrong font url is generated
2 participants