Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(squoosh): fix resize option enabled flag #356

Merged

Conversation

RAX7
Copy link
Contributor

@RAX7 RAX7 commented Sep 16, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fix enabled flag for squoosh resize option

implementation: ImageMinimizerPlugin.squooshGenerate,
options: {
  resize: {
    enabled: false, // <- do not resize
    width: 100,
    height: 50,
  },

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 88.26% // Head: 87.96% // Decreases project coverage by -0.29% ⚠️

Coverage data is based on head (56ae744) compared to base (593d116).
Patch coverage: 92.85% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   88.26%   87.96%   -0.30%     
==========================================
  Files           4        4              
  Lines         673      673              
  Branches      259      257       -2     
==========================================
- Hits          594      592       -2     
- Misses         71       73       +2     
  Partials        8        8              
Impacted Files Coverage Δ
src/utils.js 80.38% <92.85%> (-0.56%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit b2a5015 into webpack-contrib:master Sep 19, 2022
@RAX7 RAX7 deleted the fix-squoosh-resize-enabled branch September 19, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants