You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(I wasn't sure if this should be a bug report or a documentation issue. I guess it depends on whether the outcome ends up being a fix to the docs, or a fix to the code)
Bug report
According to the documentation for options.sources.list:
Using "..." syntax allows you to extend default supported tags and attributes
and...
If the tag name is not specified it will process all the tags.
Actual Behavior
When extending the default sources ("..."), omitting tag from any overrides does not work:
// This does not work
options: {sources: {list: ["...",{attribute: "my-custom-src",type: "src"}]}}
// ...but this does work
options: {sources: {list: ["...",{tag: "img",attribute: "my-custom-src",type: "src"}]}}
Expected Behavior
It should be possible to omit tag, as per the documentation.
There are no existing tests that cover this exact scenario.
(I wasn't sure if this should be a bug report or a documentation issue. I guess it depends on whether the outcome ends up being a fix to the docs, or a fix to the code)
Bug report
According to the documentation for
options.sources.list
:and...
Actual Behavior
When extending the default sources (
"..."
), omittingtag
from any overrides does not work:Expected Behavior
It should be possible to omit
tag
, as per the documentation.There are no existing tests that cover this exact scenario.
How Do We Reproduce?
A full repro can be found here:
https://github.com/scottohara/webpack-html-loader-custom-source
The text was updated successfully, but these errors were encountered: